Commit cda323db authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Uwe Kleine-König
Browse files

pwm: bcm2835: Make sure the channel is enabled after pwm_request() 



The .free callback cleared among others the enable bit PWENx in the
control register. When the PWM is requested later again this bit isn't
restored but the core assumes the PWM is enabled and thus skips a
request to configure the same state as before.

To fix that don't touch the hardware configuration in .free(). For
symmetry also drop .request() and configure the mode completely in
.apply().

Fixes: e5a06dc5 ("pwm: Add BCM2835 PWM driver")
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20251118174303.1761577-2-u.kleine-koenig@baylibre.com


Signed-off-by: default avatarUwe Kleine-König <ukleinek@kernel.org>
parent a5d51e02

drivers/pwm/pwm-bcm2835.c

+3 −25
Original line number Diff line number Diff line
@@ -34,29 +34,6 @@ static inline struct bcm2835_pwm *to_bcm2835_pwm(struct pwm_chip *chip) 
	return pwmchip_get_drvdata(chip);

}



static int bcm2835_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)

{

	struct bcm2835_pwm *pc = to_bcm2835_pwm(chip);

	u32 value;



	value = readl(pc->base + PWM_CONTROL);

	value &= ~(PWM_CONTROL_MASK << PWM_CONTROL_SHIFT(pwm->hwpwm));

	value |= (PWM_MODE << PWM_CONTROL_SHIFT(pwm->hwpwm));

	writel(value, pc->base + PWM_CONTROL);



	return 0;

}



static void bcm2835_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)

{

	struct bcm2835_pwm *pc = to_bcm2835_pwm(chip);

	u32 value;



	value = readl(pc->base + PWM_CONTROL);

	value &= ~(PWM_CONTROL_MASK << PWM_CONTROL_SHIFT(pwm->hwpwm));

	writel(value, pc->base + PWM_CONTROL);

}



static int bcm2835_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,

			     const struct pwm_state *state)

{
@@ -102,6 +79,9 @@ static int bcm2835_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, 
	/* set polarity */

	val = readl(pc->base + PWM_CONTROL);



	val &= ~(PWM_CONTROL_MASK << PWM_CONTROL_SHIFT(pwm->hwpwm));

	val |= PWM_MODE << PWM_CONTROL_SHIFT(pwm->hwpwm);



	if (state->polarity == PWM_POLARITY_NORMAL)

		val &= ~(PWM_POLARITY << PWM_CONTROL_SHIFT(pwm->hwpwm));

	else
@@ -119,8 +99,6 @@ static int bcm2835_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, 
}



static const struct pwm_ops bcm2835_pwm_ops = {

	.request = bcm2835_pwm_request,

	.free = bcm2835_pwm_free,

	.apply = bcm2835_pwm_apply,

};