Commit ce615fe3 authored by Xiang Liu's avatar Xiang Liu Committed by Alex Deucher
Browse files

drm/amdgpu: Check if CPER enabled when generating CPER 



In the case of CPER disabled, generating CPER will cause kernel NULL
pointer dereference without checking.

Signed-off-by: default avatarXiang Liu <xiang.liu@amd.com>
Reviewed-by: default avatarHawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 700e535d

drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c

+3 −0
Original line number Diff line number Diff line
@@ -392,6 +392,9 @@ static void aca_banks_generate_cper(struct amdgpu_device *adev, 
	struct aca_bank_node *node;

	struct aca_bank *bank;



	if (!adev->cper.enabled)

		return;



	if (!banks || !count) {

		dev_warn(adev->dev, "fail to generate cper records\n");

		return;

drivers/gpu/drm/amd/pm/amdgpu_dpm.c

+3 −2
Original line number Diff line number Diff line
@@ -716,6 +716,7 @@ int amdgpu_dpm_send_rma_reason(struct amdgpu_device *adev) 
	ret = smu_send_rma_reason(smu);

	mutex_unlock(&adev->pm.mutex);



	if (adev->cper.enabled)

		if (amdgpu_cper_generate_bp_threshold_record(adev))

			dev_warn(adev->dev, "fail to generate bad page threshold cper records\n");