Commit ce7f93e2 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: pcm: Make snd_pcm_suspend() local static 



snd_pcm_suspend() is no longer called from outside, so let's make it
local static.  Also drop a superfluous NULL check there.

Reviewed-by: default avatarJaroslav Kysela <perex@perex.cz>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 910e7e19

include/sound/pcm.h

+0 −5
Original line number Diff line number Diff line
@@ -582,13 +582,8 @@ int snd_pcm_stop(struct snd_pcm_substream *substream, snd_pcm_state_t status); 
int snd_pcm_drain_done(struct snd_pcm_substream *substream);

int snd_pcm_stop_xrun(struct snd_pcm_substream *substream);

#ifdef CONFIG_PM

int snd_pcm_suspend(struct snd_pcm_substream *substream);

int snd_pcm_suspend_all(struct snd_pcm *pcm);

#else

static inline int snd_pcm_suspend(struct snd_pcm_substream *substream)

{

	return 0;

}

static inline int snd_pcm_suspend_all(struct snd_pcm *pcm)

{

	return 0;

sound/core/pcm_native.c

+3 −8
Original line number Diff line number Diff line
@@ -1460,29 +1460,24 @@ static const struct action_ops snd_pcm_action_suspend = { 
	.post_action = snd_pcm_post_suspend

};



/**

/*

 * snd_pcm_suspend - trigger SUSPEND to all linked streams

 * @substream: the PCM substream

 *

 * After this call, all streams are changed to SUSPENDED state.

 *

 * Return: Zero if successful (or @substream is %NULL), or a negative error

 * code.

 * Return: Zero if successful, or a negative error code.

 */

int snd_pcm_suspend(struct snd_pcm_substream *substream)

static int snd_pcm_suspend(struct snd_pcm_substream *substream)

{

	int err;

	unsigned long flags;



	if (! substream)

		return 0;



	snd_pcm_stream_lock_irqsave(substream, flags);

	err = snd_pcm_action(&snd_pcm_action_suspend, substream, 0);

	snd_pcm_stream_unlock_irqrestore(substream, flags);

	return err;

}

EXPORT_SYMBOL(snd_pcm_suspend);



/**

 * snd_pcm_suspend_all - trigger SUSPEND to all substreams in the given pcm