Commit ceb62743 authored by Edward Cree's avatar Edward Cree Committed by Jakub Kicinski
Browse files

net: ethtool: check rxfh_max_num_contexts != 1 at register time 



A value of 1 doesn't make sense, as it implies the only allowed
 context ID is 0, which is reserved for the default context - in
 which case the driver should just not claim to support custom
 RSS contexts at all.

Suggested-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarEdward Cree <ecree.xilinx@gmail.com>
Link: https://lore.kernel.org/c07725b3a3d0b0a63b85e230f9c77af59d4d07f8.1723045898.git.ecree.xilinx@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent df665ab1

net/ethtool/common.c

+2 −0
Original line number Diff line number Diff line
@@ -654,6 +654,8 @@ int ethtool_check_ops(const struct ethtool_ops *ops) 
{

	if (WARN_ON(ops->set_coalesce && !ops->supported_coalesce_params))

		return -EINVAL;

	if (WARN_ON(ops->rxfh_max_num_contexts == 1))

		return -EINVAL;

	/* NOTE: sufficiently insane drivers may swap ethtool_ops at runtime,

	 * the fact that ops are checked at registration time does not

	 * mean the ops attached to a netdev later on are sane.