Commit cec780a1 authored by Qu Wenruo's avatar Qu Wenruo Committed by David Sterba
Browse files

btrfs: output more info when btrfs_subpage_assert() failed 



The function btrfs_subpage_assert() is a very commonly utilized assert
to make sure the range passed in is correct inside the folio.

And when some code is not properly subpage/large folio compatible
btrfs_subpage_assert() will be the first to be triggered.
E.g. when I incorrectly enabled large folios for data reloc inodes, it
immediately triggered btrfs_subpage_assert().

In that case, outputting all the involved members will be very helpful,
this includes:

- start
- len
- folio position inside the mapping
- folio size

Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 4e346bae

fs/btrfs/subpage.c

+3 −2
Original line number Diff line number Diff line
@@ -186,8 +186,9 @@ static void btrfs_subpage_assert(const struct btrfs_fs_info *fs_info, 
	 * unmapped page like dummy extent buffer pages.

	 */

	if (folio->mapping)

		ASSERT(folio_pos(folio) <= start &&

		       start + len <= folio_end(folio));

		ASSERT(folio_pos(folio) <= start && start + len <= folio_end(folio),

		       "start=%llu len=%u folio_pos=%llu folio_size=%zu",

		       start, len, folio_pos(folio), folio_size(folio));

}



#define subpage_calc_start_bit(fs_info, folio, name, start, len)	\