Commit cf44ae3d authored by Bard Liao's avatar Bard Liao Committed by Vinod Koul
Browse files

soundwire: generic_bandwidth_allocation: correct clk_freq check in sdw_select_row_col 



The bits in Column 0 of Rows 0 to 47 are for control word and cannot be
used for audio. In practice, entire Column 0 is skipped.

Signed-off-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20241218080155.102405-10-yung-chuan.liao@linux.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 3ddd303f

drivers/soundwire/generic_bandwidth_allocation.c

+2 −6
Original line number Diff line number Diff line
@@ -302,7 +302,6 @@ static int sdw_compute_port_params(struct sdw_bus *bus) 
static int sdw_select_row_col(struct sdw_bus *bus, int clk_freq)

{

	struct sdw_master_prop *prop = &bus->prop;

	int frame_int, frame_freq;

	int r, c;



	for (c = 0; c < SDW_FRAME_COLS; c++) {
@@ -311,11 +310,8 @@ static int sdw_select_row_col(struct sdw_bus *bus, int clk_freq) 
			    sdw_cols[c] != prop->default_col)

				continue;



			frame_int = sdw_rows[r] * sdw_cols[c];

			frame_freq = clk_freq / frame_int;



			if ((clk_freq - (frame_freq * SDW_FRAME_CTRL_BITS)) <

			    bus->params.bandwidth)

			if (clk_freq * (sdw_cols[c] - 1) <

			    bus->params.bandwidth * sdw_cols[c])

				continue;



			bus->params.row = sdw_rows[r];