Commit cf46019e authored by Dan Carpenter's avatar Dan Carpenter Committed by Matthew Brost
Browse files

drm/xe: unlock on error path in xe_vm_add_compute_exec_queue() 



Drop the "&vm->lock" before returning.

Fixes: 24f947d5 ("drm/xe: Use DRM GPUVM helpers for external- and evicted objects")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarMatthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
parent 88ec2352

drivers/gpu/drm/xe/xe_vm.c

+4 −3
Original line number Diff line number Diff line
@@ -335,13 +335,13 @@ int xe_vm_add_compute_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q) 
	down_write(&vm->lock);

	err = drm_gpuvm_exec_lock(&vm_exec);

	if (err)

		return err;

		goto out_up_write;



	pfence = xe_preempt_fence_create(q, q->compute.context,

					 ++q->compute.seqno);

	if (!pfence) {

		err = -ENOMEM;

		goto out_unlock;

		goto out_fini;

	}



	list_add(&q->compute.link, &vm->preempt.exec_queues);
@@ -364,8 +364,9 @@ int xe_vm_add_compute_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q) 


	up_read(&vm->userptr.notifier_lock);



out_unlock:

out_fini:

	drm_exec_fini(exec);

out_up_write:

	up_write(&vm->lock);



	return err;