Unverified Commit cf4d7425 authored by Cezary Rojewski's avatar Cezary Rojewski Committed by Mark Brown
Browse files

ASoC: Intel: avs: Fix theoretical infinite loop 



While 'stack_dump_size' is a u32 bitfield of 16 bits, u32 has a bigger
upper bound than the type u16 of loop counter 'offset' what in theory
may lead to infinite loop condition.

Found out by Coverity static analyzer.

Fixes: c8c960c1 ("ASoC: Intel: avs: APL-based platforms support")
Signed-off-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20250109122216.3667847-4-cezary.rojewski@intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent dbda5c35

sound/soc/intel/avs/apl.c

+1 −1
Original line number Diff line number Diff line
@@ -125,7 +125,7 @@ int avs_apl_coredump(struct avs_dev *adev, union avs_notify_msg *msg) 
	struct avs_apl_log_buffer_layout layout;

	void __iomem *addr, *buf;

	size_t dump_size;

	u16 offset = 0;

	u32 offset = 0;

	u8 *dump, *pos;



	dump_size = AVS_FW_REGS_SIZE + msg->ext.coredump.stack_dump_size;