Commit cf57ee16 authored by Rosen Penev's avatar Rosen Penev Committed by Jakub Kicinski
Browse files

amd-xgbe: use ethtool string helpers 



The latter is the preferred way to copy ethtool strings.

Avoids manually incrementing the pointer.

Signed-off-by: default avatarRosen Penev <rosenp@gmail.com>
Acked-by: default avatarShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241022233203.9670-1-rosenp@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ae2930b0

drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c

+9 −13
Original line number Diff line number Diff line
@@ -195,23 +195,19 @@ static void xgbe_get_strings(struct net_device *netdev, u32 stringset, u8 *data) 


	switch (stringset) {

	case ETH_SS_STATS:

		for (i = 0; i < XGBE_STATS_COUNT; i++) {

			memcpy(data, xgbe_gstring_stats[i].stat_string,

			       ETH_GSTRING_LEN);

			data += ETH_GSTRING_LEN;

		}

		for (i = 0; i < XGBE_STATS_COUNT; i++)

			ethtool_puts(&data, xgbe_gstring_stats[i].stat_string);



		for (i = 0; i < pdata->tx_ring_count; i++) {

			sprintf(data, "txq_%u_packets", i);

			data += ETH_GSTRING_LEN;

			sprintf(data, "txq_%u_bytes", i);

			data += ETH_GSTRING_LEN;

			ethtool_sprintf(&data, "txq_%u_packets", i);

			ethtool_sprintf(&data, "txq_%u_bytes", i);

		}



		for (i = 0; i < pdata->rx_ring_count; i++) {

			sprintf(data, "rxq_%u_packets", i);

			data += ETH_GSTRING_LEN;

			sprintf(data, "rxq_%u_bytes", i);

			data += ETH_GSTRING_LEN;

			ethtool_sprintf(&data, "rxq_%u_packets", i);

			ethtool_sprintf(&data, "rxq_%u_bytes", i);

		}



		break;

	}

}