Commit cf8da329 authored by Ricardo Ribalda's avatar Ricardo Ribalda Committed by Hans Verkuil
Browse files

media: c8sectpfe: Refactor load_c8sectpfe_fw 



release_firmware() in the same function that it was requested. It is
more clear and makes smatch happy.

drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c:1146 load_c8sectpfe_fw() warn: 'fw' from request_firmware() not released on lines: 1125,1132.

Signed-off-by: default avatarRicardo Ribalda <ribalda@chromium.org>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent 179559ed

drivers/media/platform/st/sti/c8sectpfe/c8sectpfe-core.c

+1 −1
Original line number Diff line number Diff line
@@ -1096,7 +1096,6 @@ static int load_slim_core_fw(const struct firmware *fw, struct c8sectpfei *fei) 
		}

	}



	release_firmware(fw);

	return err;

}
@@ -1120,6 +1119,7 @@ static int load_c8sectpfe_fw(struct c8sectpfei *fei) 
	}



	err = load_slim_core_fw(fw, fei);

	release_firmware(fw);

	if (err) {

		dev_err(fei->dev, "load_slim_core_fw failed err=(%d)\n", err);

		return err;