Commit d03a493f authored by Colin Ian King's avatar Colin Ian King Committed by Thomas Zimmermann
Browse files

drm/mgag200: Fix uninitialized variable delta 



The variable delta is not initialized and this will cause unexpected
behaviour with the comparison of tmpdelta < delta. Fix this by setting
it to 0xffffffff. This matches the behaviour as in the similar function
mgag200_pixpll_compute_g200se_04.

v2:
	* move fix up by one line to align style with other functions
	* add additional tags from similar patch

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Fixes: 2545ac96 ("drm/mgag200: Abstract pixel PLL via struct mgag200_pll")
Addresses-Coverity: ("Uninitialized scalar variable")
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Dave Airlie <airlied@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Link: https://patchwork.freedesktop.org/patch/msgid/20210817163204.494166-1-colin.king@canonical.com
parent 17d3d3a6

drivers/gpu/drm/mgag200/mgag200_pll.c

+1 −0
Original line number Diff line number Diff line
@@ -124,6 +124,7 @@ static int mgag200_pixpll_compute_g200se_00(struct mgag200_pll *pixpll, long clo 
	unsigned int computed;



	m = n = p = s = 0;

	delta = 0xffffffff;

	permitteddelta = clock * 5 / 1000;



	for (testp = 8; testp > 0; testp /= 2) {