Commit d12a7be0 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Paolo Abeni
Browse files

tools: ynl-gen: fill in missing empty attr lists 



The C codegen refers to op attribute lists all over the place,
without checking if they are present, even tho attribute list
is technically an optional property. Add them automatically
at init if missing so that we don't have to make specs longer.

Reviewed-by: default avatarDonald Hunter <donald.hunter@gmail.com>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20250429154704.2613851-4-kuba@kernel.org


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 2286905f

tools/net/ynl/pyynl/ynl_gen_c.py

+8 −0
Original line number Diff line number Diff line
@@ -938,6 +938,14 @@ class AttrSet(SpecAttrSet): 


class Operation(SpecOperation):

    def __init__(self, family, yaml, req_value, rsp_value):

        # Fill in missing operation properties (for fixed hdr-only msgs)

        for mode in ['do', 'dump', 'event']:

            for direction in ['request', 'reply']:

                try:

                    yaml[mode][direction].setdefault('attributes', [])

                except KeyError:

                    pass



        super().__init__(family, yaml, req_value, rsp_value)



        self.render_name = c_lower(family.ident_name + '_' + self.name)