Commit d1f6d6c5 authored by Danilo Krummrich's avatar Danilo Krummrich Committed by Greg Kroah-Hartman
Browse files

rust: pci: use to_result() in enable_device_mem() 



Simplify enable_device_mem() by using to_result() to handle the return
value of the corresponding FFI call.

Reviewed-by: default avatarBenno Lossin <benno.lossin@proton.me>
Signed-off-by: default avatarDanilo Krummrich <dakr@kernel.org>
Acked-by: default avatarBoqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20250314160932.100165-2-dakr@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e0196842

rust/kernel/pci.rs

+1 −6
Original line number Diff line number Diff line
@@ -382,12 +382,7 @@ pub fn device_id(&self) -> u16 { 
    /// Enable memory resources for this device.

    pub fn enable_device_mem(&self) -> Result {

        // SAFETY: `self.as_raw` is guaranteed to be a pointer to a valid `struct pci_dev`.

        let ret = unsafe { bindings::pci_enable_device_mem(self.as_raw()) };

        if ret != 0 {

            Err(Error::from_errno(ret))

        } else {

            Ok(())

        }

        to_result(unsafe { bindings::pci_enable_device_mem(self.as_raw()) })

    }



    /// Enable bus-mastering for this device.