Commit d26e8534 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/exynos: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct() 



Plumb the format info from .fb_create() all the way to
drm_helper_mode_fill_fb_struct() to avoid the redundant
lookup.

For the fbdev case a manual drm_get_format_info() lookup
is needed.

Cc: Inki Dae <inki.dae@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250701090722.13645-12-ville.syrjala@linux.intel.com
parent 797f8fc4

drivers/gpu/drm/exynos/exynos_drm_fb.c

+3 −2
Original line number Diff line number Diff line
@@ -56,6 +56,7 @@ static const struct drm_framebuffer_funcs exynos_drm_fb_funcs = { 


struct drm_framebuffer *

exynos_drm_framebuffer_init(struct drm_device *dev,

			    const struct drm_format_info *info,

			    const struct drm_mode_fb_cmd2 *mode_cmd,

			    struct exynos_drm_gem **exynos_gem,

			    int count)
@@ -76,7 +77,7 @@ exynos_drm_framebuffer_init(struct drm_device *dev, 
		fb->obj[i] = &exynos_gem[i]->base;

	}



	drm_helper_mode_fill_fb_struct(dev, fb, NULL, mode_cmd);

	drm_helper_mode_fill_fb_struct(dev, fb, info, mode_cmd);



	ret = drm_framebuffer_init(dev, fb, &exynos_drm_fb_funcs);

	if (ret < 0) {
@@ -124,7 +125,7 @@ exynos_user_fb_create(struct drm_device *dev, struct drm_file *file_priv, 
		}

	}



	fb = exynos_drm_framebuffer_init(dev, mode_cmd, exynos_gem, i);

	fb = exynos_drm_framebuffer_init(dev, info, mode_cmd, exynos_gem, i);

	if (IS_ERR(fb)) {

		ret = PTR_ERR(fb);

		goto err;

drivers/gpu/drm/exynos/exynos_drm_fb.h

+1 −0
Original line number Diff line number Diff line
@@ -14,6 +14,7 @@ 


struct drm_framebuffer *

exynos_drm_framebuffer_init(struct drm_device *dev,

			    const struct drm_format_info *info,

			    const struct drm_mode_fb_cmd2 *mode_cmd,

			    struct exynos_drm_gem **exynos_gem,

			    int count);

drivers/gpu/drm/exynos/exynos_drm_fbdev.c

+4 −1
Original line number Diff line number Diff line
@@ -116,7 +116,10 @@ int exynos_drm_fbdev_driver_fbdev_probe(struct drm_fb_helper *helper, 
		return PTR_ERR(exynos_gem);



	helper->fb =

		exynos_drm_framebuffer_init(dev, &mode_cmd, &exynos_gem, 1);

		exynos_drm_framebuffer_init(dev,

					    drm_get_format_info(dev, mode_cmd.pixel_format,

								mode_cmd.modifier[0]),

					    &mode_cmd, &exynos_gem, 1);

	if (IS_ERR(helper->fb)) {

		DRM_DEV_ERROR(dev->dev, "failed to create drm framebuffer.\n");

		ret = PTR_ERR(helper->fb);