Unverified Commit d32c4e58 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Mark Brown
Browse files

spi: SPI_QPIC_SNAND should be tristate and depend on MTD 



SPI_QPIC_SNAND is the only driver that selects MTD instead of depending
on it, which could lead to circular dependencies.  Moreover, as
SPI_QPIC_SNAND is bool, this forces MTD (and various related symbols) to
be built-in, as can be seen in an allmodconfig kernel.

Except for a missing semicolon, there is no reason why SPI_QPIC_SNAND
cannot be tristate; all MODULE_*() boilerplate is already present.
Hence make SPI_QPIC_SNAND tristate, let it depend on MTD, and add the
missing semicolon.

Fixes: 7304d190 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://patch.msgid.link/b63db431cbf35223a4400e44c296293d32c4543c.1742998909.git.geert+renesas@glider.be


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 7a874e8b

drivers/spi/Kconfig

+2 −2
Original line number Diff line number Diff line
@@ -937,9 +937,9 @@ config SPI_QCOM_QSPI 
	  QSPI(Quad SPI) driver for Qualcomm QSPI controller.



config SPI_QPIC_SNAND

	bool "QPIC SNAND controller"

	tristate "QPIC SNAND controller"

	depends on ARCH_QCOM || COMPILE_TEST

	select MTD

	depends on MTD

	help

	  QPIC_SNAND (QPIC SPI NAND) driver for Qualcomm QPIC controller.

	  QPIC controller supports both parallel nand and serial nand.

drivers/spi/spi-qpic-snand.c

+1 −1
Original line number Diff line number Diff line
@@ -1614,7 +1614,7 @@ static const struct of_device_id qcom_snandc_of_match[] = { 
		.data = &ipq9574_snandc_props,

	},

	{}

}

};

MODULE_DEVICE_TABLE(of, qcom_snandc_of_match);



static struct platform_driver qcom_spi_driver = {