Commit d364eee1 authored Feb 05, 2025 by Dhananjay Ugwekar Committed by Mario Limonciello Feb 05, 2025

cpufreq/amd-pstate: Remove the goto label in amd_pstate_update_limits

Scope based guard/cleanup macros should not be used together with goto
labels. Hence, remove the goto label.

Fixes: 6c093d5a ("cpufreq/amd-pstate: convert mutex use to guard()")
Signed-off-by: Dhananjay Ugwekar <dhananjay.ugwekar@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20250205112523.201101-2-dhananjay.ugwekar@amd.com

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

parent fa803513

drivers/cpufreq/amd-pstate.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -838,8 +838,10 @@ static void amd_pstate_update_limits(unsigned int cpu)
		guard(mutex)(&amd_pstate_driver_lock);

		ret = amd_get_highest_perf(cpu, &cur_high);
		if (ret)
		goto free_cpufreq_put;
		if (ret) {
		cpufreq_cpu_put(policy);
		return;
		}

		prev_high = READ_ONCE(cpudata->prefcore_ranking);
		highest_perf_changed = (prev_high != cur_high);
		@@ -849,8 +851,6 @@ static void amd_pstate_update_limits(unsigned int cpu)
		if (cur_high < CPPC_MAX_PERF)
		sched_set_itmt_core_prio((int)cur_high, cpu);
		}

		free_cpufreq_put:
		cpufreq_cpu_put(policy);

		if (!highest_perf_changed)