Commit d437dab5 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thomas Zimmermann
Browse files

drm/etnaviv: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert the etnaviv drm driver from always returning zero in
the remove callback to the void returning variant.

Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarJyri Sarha <jyri.sarha@iki.fi>
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarChristian Gmeiner <cgmeiner@igalia.com>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231102165640.3307820-25-u.kleine-koenig@pengutronix.de
parent 3cdbe598

drivers/gpu/drm/etnaviv/etnaviv_drv.c

+2 −4
Original line number Diff line number Diff line
@@ -640,16 +640,14 @@ static int etnaviv_pdev_probe(struct platform_device *pdev) 
	return component_master_add_with_match(dev, &etnaviv_master_ops, match);

}



static int etnaviv_pdev_remove(struct platform_device *pdev)

static void etnaviv_pdev_remove(struct platform_device *pdev)

{

	component_master_del(&pdev->dev, &etnaviv_master_ops);



	return 0;

}



static struct platform_driver etnaviv_platform_driver = {

	.probe      = etnaviv_pdev_probe,

	.remove     = etnaviv_pdev_remove,

	.remove_new = etnaviv_pdev_remove,

	.driver     = {

		.name   = "etnaviv",

	},

drivers/gpu/drm/etnaviv/etnaviv_gpu.c

+2 −3
Original line number Diff line number Diff line
@@ -1904,11 +1904,10 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev) 
	return 0;

}



static int etnaviv_gpu_platform_remove(struct platform_device *pdev)

static void etnaviv_gpu_platform_remove(struct platform_device *pdev)

{

	component_del(&pdev->dev, &gpu_ops);

	pm_runtime_disable(&pdev->dev);

	return 0;

}



static int etnaviv_gpu_rpm_suspend(struct device *dev)
@@ -1970,6 +1969,6 @@ struct platform_driver etnaviv_gpu_driver = { 
		.of_match_table = etnaviv_gpu_match,

	},

	.probe = etnaviv_gpu_platform_probe,

	.remove = etnaviv_gpu_platform_remove,

	.remove_new = etnaviv_gpu_platform_remove,

	.id_table = gpu_ids,

};