Commit d447e794 authored by Volker Lendecke's avatar Volker Lendecke Committed by Steve French
Browse files

cifs: Fix uninitialized memory read in smb3_qfs_tcon() 



oparms was not fully initialized

Signed-off-by: default avatarVolker Lendecke <vl@samba.org>
Reviewed-by: default avatarPaulo Alcantara (SUSE) <pc@cjr.nz>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 3891f6c7

fs/cifs/smb2ops.c

+7 −6
Original line number Diff line number Diff line
@@ -729,12 +729,13 @@ smb3_qfs_tcon(const unsigned int xid, struct cifs_tcon *tcon, 
	struct cifs_fid fid;

	struct cached_fid *cfid = NULL;



	oparms.tcon = tcon;

	oparms.desired_access = FILE_READ_ATTRIBUTES;

	oparms.disposition = FILE_OPEN;

	oparms.create_options = cifs_create_options(cifs_sb, 0);

	oparms.fid = &fid;

	oparms.reconnect = false;

	oparms = (struct cifs_open_parms) {

		.tcon = tcon,

		.desired_access = FILE_READ_ATTRIBUTES,

		.disposition = FILE_OPEN,

		.create_options = cifs_create_options(cifs_sb, 0),

		.fid = &fid,

	};



	rc = open_cached_dir(xid, tcon, "", cifs_sb, false, &cfid);

	if (rc == 0)