Commit d4b2c748 authored by Yang Li's avatar Yang Li Committed by Bjorn Andersson
Browse files

soc: qcom: dcc: Fix unsigned comparison with less than zero 

The return value from the call to kstrtouint_from_user() is int.
However, the return value is being assigned to
an unsigned int variable 'ret', so making 'ret' an int.

Eliminate the following warning:
./drivers/soc/qcom/dcc.c:815:5-8: WARNING: Unsigned expression compared with zero: ret < 0

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3638


Fixes: 4cbe60cf ("soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC)")
Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230106011710.2827-1-yang.lee@linux.alibaba.com
parent 33ae3d09

drivers/soc/qcom/dcc.c

+2 −1
Original line number Diff line number Diff line
@@ -808,7 +808,8 @@ static ssize_t config_reset_write(struct file *filp, 
				  const char __user *user_buf, size_t count,

				  loff_t *ppos)

{

	unsigned int val, ret;

	unsigned int val;

	int ret;

	struct dcc_drvdata *drvdata = filp->private_data;



	ret = kstrtouint_from_user(user_buf, count, 0, &val);