Commit d5078509 authored by Hugo Villeneuve's avatar Hugo Villeneuve Committed by Greg Kroah-Hartman
Browse files

serial: sc16is7xx: improve do/while loop in sc16is7xx_irq() 



Simplify and improve readability by replacing while(1) loop with
do {} while, and by using the keep_polling variable as the exit
condition, making it more explicit.

Fixes: 83444987 ("sc16is7xx: Fix for multi-channel stall")
Cc:  <stable@vger.kernel.org>
Suggested-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarHugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/20231221231823.2327894-6-hugo@hugovil.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ed647256

drivers/tty/serial/sc16is7xx.c

+6 −5
Original line number Diff line number Diff line
@@ -783,17 +783,18 @@ static bool sc16is7xx_port_irq(struct sc16is7xx_port *s, int portno) 


static irqreturn_t sc16is7xx_irq(int irq, void *dev_id)

{

	bool keep_polling;



	struct sc16is7xx_port *s = (struct sc16is7xx_port *)dev_id;



	while (1) {

		bool keep_polling = false;

	do {

		int i;



		keep_polling = false;



		for (i = 0; i < s->devtype->nr_uart; ++i)

			keep_polling |= sc16is7xx_port_irq(s, i);

		if (!keep_polling)

			break;

	}

	} while (keep_polling);



	return IRQ_HANDLED;

}