Commit d586676a authored by Alok Tiwari's avatar Alok Tiwari Committed by Jakub Kicinski
Browse files

ionic: use int type for err in ionic_get_module_eeprom_by_page 



The variable 'err' is declared as u32, but it is used to store
negative error codes such as -EINVAL.

Changing the type of 'err' to int ensures proper representation of
negative error codes and aligns with standard kernel error handling
conventions.

Also, there is no need to initialize 'err' since it is always set
before being used.

Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: default avatarShannon Nelson <sln@onemain.com>
Reviewed-by: default avatarBrett Creeley <brett.creeley@amd.com>
Link: https://patch.msgid.link/20250912141426.3922545-1-alok.a.tiwari@oracle.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c20302dd

drivers/net/ethernet/pensando/ionic/ionic_ethtool.c

+1 −1
Original line number Diff line number Diff line
@@ -978,7 +978,7 @@ static int ionic_get_module_eeprom_by_page(struct net_device *netdev, 
{

	struct ionic_lif *lif = netdev_priv(netdev);

	struct ionic_dev *idev = &lif->ionic->idev;

	u32 err = -EINVAL;

	int err;

	u8 *src;



	if (!page_data->length)