Commit d58bfcd4 authored by Arun R Murthy's avatar Arun R Murthy Committed by Jani Nikula
Browse files

drm/i915/display: Print useful information on error 



For modifier not supporting async flip, print the modifier and display
version. Helps in reading the error message.

v2: Reframe the error message (Jani)

Signed-off-by: default avatarArun R Murthy <arun.r.murthy@intel.com>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230602022157.221225-1-arun.r.murthy@intel.com
parent 619a06db

drivers/gpu/drm/i915/display/intel_display.c

+6 −4
Original line number Diff line number Diff line
@@ -6012,8 +6012,9 @@ static int intel_async_flip_check_hw(struct intel_atomic_state *state, struct in 
			 */

			if (DISPLAY_VER(i915) < 12) {

				drm_dbg_kms(&i915->drm,

					    "[PLANE:%d:%s] Modifier does not support async flips\n",

					    plane->base.base.id, plane->base.name);

					    "[PLANE:%d:%s] Modifier 0x%llx does not support async flip on display ver %d\n",

					    plane->base.base.id, plane->base.name,

					    new_plane_state->hw.fb->modifier, DISPLAY_VER(i915));

				return -EINVAL;

			}

			break;
@@ -6025,8 +6026,9 @@ static int intel_async_flip_check_hw(struct intel_atomic_state *state, struct in 
			break;

		default:

			drm_dbg_kms(&i915->drm,

				    "[PLANE:%d:%s] Modifier does not support async flips\n",

				    plane->base.base.id, plane->base.name);

				    "[PLANE:%d:%s] Modifier 0x%llx does not support async flip\n",

				    plane->base.base.id, plane->base.name,

				    new_plane_state->hw.fb->modifier);

			return -EINVAL;

		}