Unverified Commit d641def1 authored by Simon Trimmer's avatar Simon Trimmer Committed by Mark Brown
Browse files

ALSA: hda: hda_cs_dsp_ctl: Remove notification of driver write 



Any control that the driver is updating should be marked as SYSTEM and
therefore will not have an ALSA control to notify.

Signed-off-by: default avatarSimon Trimmer <simont@opensource.cirrus.com>
Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://msgid.link/r/20240325113127.112783-6-rf@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e81f5c9f

sound/pci/hda/hda_cs_dsp_ctl.c

+0 −8
Original line number Diff line number Diff line
@@ -201,7 +201,6 @@ int hda_cs_dsp_write_ctl(struct cs_dsp *dsp, const char *name, int type, 
			 unsigned int alg, const void *buf, size_t len)

{

	struct cs_dsp_coeff_ctl *cs_ctl;

	struct hda_cs_dsp_coeff_ctl *ctl;

	int ret;



	mutex_lock(&dsp->pwr_lock);
@@ -211,13 +210,6 @@ int hda_cs_dsp_write_ctl(struct cs_dsp *dsp, const char *name, int type, 
	if (ret < 0)

		return ret;



	if (ret == 0 || (cs_ctl->flags & WMFW_CTL_FLAG_SYS))

		return 0;



	ctl = cs_ctl->priv;



	snd_ctl_notify(ctl->card, SNDRV_CTL_EVENT_MASK_VALUE, &ctl->kctl->id);



	return 0;

}

EXPORT_SYMBOL_NS_GPL(hda_cs_dsp_write_ctl, SND_HDA_CS_DSP_CONTROLS);