Commit d699628d authored Apr 08, 2025 by Matthias Schiffer Committed by Simon Wunderlich Apr 09, 2025

batman-adv: constify and move broadcast addr definition



The variable is used only once and is read-only. Make it a const local
variable.

Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>

parent 4a1cff31

net/batman-adv/main.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -69,8 +69,6 @@ unsigned int batadv_hardif_generation;
		static int (batadv_rx_handler[256])(struct sk_buff skb,
		struct batadv_hard_iface *recv_if);

		unsigned char batadv_broadcast_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};

		struct workqueue_struct *batadv_event_workqueue;

		static void batadv_recv_handler_init(void);

net/batman-adv/main.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -235,7 +235,6 @@ static inline int batadv_print_vid(unsigned short vid)
		extern struct list_head batadv_hardif_list;
		extern unsigned int batadv_hardif_generation;

		extern unsigned char batadv_broadcast_addr[];
		extern struct workqueue_struct *batadv_event_workqueue;

		int batadv_mesh_init(struct net_device *mesh_iface);

net/batman-adv/send.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -124,7 +124,9 @@ int batadv_send_skb_packet(struct sk_buff *skb,
		int batadv_send_broadcast_skb(struct sk_buff *skb,
		struct batadv_hard_iface *hard_iface)
		{
		return batadv_send_skb_packet(skb, hard_iface, batadv_broadcast_addr);
		static const u8 broadcast_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};

		return batadv_send_skb_packet(skb, hard_iface, broadcast_addr);
		}

		/**