Commit d7073e8b authored by Shay Drory's avatar Shay Drory Committed by Jakub Kicinski
Browse files

net/mlx5: E-switch, Clear legacy flag when moving to switchdev 



The cited commit introduced MLX5_PRIV_FLAGS_SWITCH_LEGACY to identify
when a transition to legacy mode is requested via devlink.  However, the
logic failed to clear this flag if the mode was subsequently changed
back to MLX5_ESWITCH_OFFLOADS (switchdev).  Consequently, if a user
toggled from legacy to switchdev, the flag remained set, leaving the
driver with wrong state indicating

Fix this by explicitly clearing the MLX5_PRIV_FLAGS_SWITCH_LEGACY bit
when the requested mode is MLX5_ESWITCH_OFFLOADS.

Fixes: 2a4f56fb ("net/mlx5e: Keep netdev when leave switchdev for devlink set legacy only")
Signed-off-by: default avatarShay Drory <shayd@nvidia.com>
Reviewed-by: default avatarMark Bloch <mbloch@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260224114652.1787431-4-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent bd7b9f83

drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c

+2 −0
Original line number Diff line number Diff line
@@ -4068,6 +4068,8 @@ int mlx5_devlink_eswitch_mode_set(struct devlink *devlink, u16 mode, 


	if (mlx5_mode == MLX5_ESWITCH_LEGACY)

		esw->dev->priv.flags |= MLX5_PRIV_FLAGS_SWITCH_LEGACY;

	if (mlx5_mode == MLX5_ESWITCH_OFFLOADS)

		esw->dev->priv.flags &= ~MLX5_PRIV_FLAGS_SWITCH_LEGACY;

	mlx5_eswitch_disable_locked(esw);

	if (mlx5_mode == MLX5_ESWITCH_OFFLOADS) {

		if (mlx5_devlink_trap_get_num_active(esw->dev)) {