Commit d80eee97 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

usb: typec: qcom-pmic: fix use-after-free on late probe errors 



Make sure to stop and deregister the port in case of late probe errors
to avoid use-after-free issues when the underlying memory is released by
devres.

Fixes: a4422ff2 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
Cc: stable@vger.kernel.org	# 6.5
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan+linaro@kernel.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240418145730.4605-2-johan+linaro@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0aea736d

drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c

+6 −2
Original line number Diff line number Diff line
@@ -104,14 +104,18 @@ static int qcom_pmic_typec_probe(struct platform_device *pdev) 


	ret = tcpm->port_start(tcpm, tcpm->tcpm_port);

	if (ret)

		goto fwnode_remove;

		goto port_unregister;



	ret = tcpm->pdphy_start(tcpm, tcpm->tcpm_port);

	if (ret)

		goto fwnode_remove;

		goto port_stop;



	return 0;



port_stop:

	tcpm->port_stop(tcpm);

port_unregister:

	tcpm_unregister_port(tcpm->tcpm_port);

fwnode_remove:

	fwnode_remove_software_node(tcpm->tcpc.fwnode);