Commit d8731500 authored by Matthew Auld's avatar Matthew Auld Committed by Rodrigo Vivi
Browse files

drm/xe/pcode: fix pcode error check 



On DG2 we are now getting:

[  104.456607] xe 0000:03:00.0: [drm] *ERROR* PCODE timeout, retrying with preemption disabled

Looks like we just need to invert the error check for
xe_pcode_try_request(), which returns zero on success.

Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 2c33b49a

drivers/gpu/drm/xe/xe_pcode.c

+1 −1
Original line number Diff line number Diff line
@@ -155,7 +155,7 @@ int xe_pcode_request(struct xe_gt *gt, u32 mbox, u32 request, 


	ret = xe_pcode_try_request(gt, mbox, request, reply_mask, reply, &status,

				   false, timeout_base_ms * 1000);

	if (ret)

	if (!ret)

		goto out;



	/*