Commit d97fb257 authored by Wolfram Sang's avatar Wolfram Sang Committed by Greg Kroah-Hartman
Browse files

misc: ti-st: st_kim: use 'time_left' variable with wait_for_completion_interruptible_timeout() 



There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_interruptible_timeout() causing patterns like:

	timeout = wait_for_completion_interruptible_timeout(...)
	if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240604212240.4529-5-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4c0fb1af

drivers/misc/ti-st/st_kim.c

+4 −4
Original line number Diff line number Diff line
@@ -198,7 +198,7 @@ static long read_local_version(struct kim_data_s *kim_gdata, char *bts_scr_name) 
{

	unsigned short version = 0, chip = 0, min_ver = 0, maj_ver = 0;

	static const char read_ver_cmd[] = { 0x01, 0x01, 0x10, 0x00 };

	long timeout;

	long time_left;



	pr_debug("%s", __func__);
@@ -208,11 +208,11 @@ static long read_local_version(struct kim_data_s *kim_gdata, char *bts_scr_name) 
		return -EIO;

	}



	timeout = wait_for_completion_interruptible_timeout(

	time_left = wait_for_completion_interruptible_timeout(

		&kim_gdata->kim_rcvd, msecs_to_jiffies(CMD_RESP_TIME));

	if (timeout <= 0) {

	if (time_left <= 0) {

		pr_err(" waiting for ver info- timed out or received signal");

		return timeout ? -ERESTARTSYS : -ETIMEDOUT;

		return time_left ? -ERESTARTSYS : -ETIMEDOUT;

	}

	reinit_completion(&kim_gdata->kim_rcvd);

	/*