Commit da717540 authored by Johan Hovold's avatar Johan Hovold Committed by Jakub Kicinski
Browse files

net: gianfar: fix device leak when querying time stamp info 



Make sure to drop the reference to the ptp device taken by
of_find_device_by_node() when querying the time stamping capabilities.

Note that holding a reference to the ptp device does not prevent its
driver data from going away.

Fixes: 7349a74e ("net: ethernet: gianfar_ethtool: get phc index through drvdata")
Cc: stable@vger.kernel.org	# 4.18
Cc: Yangbo Lu <yangbo.lu@nxp.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250725171213.880-4-johan@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 70458f8a

drivers/net/ethernet/freescale/gianfar_ethtool.c

+3 −1
Original line number Diff line number Diff line
@@ -1475,8 +1475,10 @@ static int gfar_get_ts_info(struct net_device *dev, 
	if (ptp_node) {

		ptp_dev = of_find_device_by_node(ptp_node);

		of_node_put(ptp_node);

		if (ptp_dev)

		if (ptp_dev) {

			ptp = platform_get_drvdata(ptp_dev);

			put_device(&ptp_dev->dev);

		}

	}



	if (ptp)