Commit da7aee71 authored by Jason Xing's avatar Jason Xing Committed by Jakub Kicinski
Browse files

net: xsk: dpaa2: avoid repeatedly updating the global consumer 



This patch avoids another update of the consumer at the end of
dpaa2_xsk_tx().

In the zero copy xmit path, two versions (batched and non-batched)
regarding how the consumer of tx ring changes are implemented in
xsk_tx_peek_release_desc_batch() that eventually updates the local
consumer to the global consumer in either of the following call trace:
1) batched mode:
   xsk_tx_peek_release_desc_batch()
       __xskq_cons_release()
2) non-batched mode:
   xsk_tx_peek_release_desc_batch()
       xsk_tx_peek_release_fallback()
           xsk_tx_release()

As we can see, dpaa2_xsk_tx() doesn't need to call extra release function
to handle the sync of consumer itself.

Signed-off-by: default avatarJason Xing <kernelxing@tencent.com>
Acked-by: default avatarMaciej Fijalkowski <maciej.fijalkowski@intel.com>
Link: https://patch.msgid.link/20250623120159.68374-1-kerneljasonxing@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a19e5812

drivers/net/ethernet/freescale/dpaa2/dpaa2-xsk.c

+0 −2
Original line number Diff line number Diff line
@@ -448,7 +448,5 @@ bool dpaa2_xsk_tx(struct dpaa2_eth_priv *priv, 
		percpu_stats->tx_errors++;

	}



	xsk_tx_release(ch->xsk_pool);



	return total_enqueued == budget;

}