Commit db37c6e5 authored by Inochi Amaoto's avatar Inochi Amaoto Committed by Jakub Kicinski
Browse files

net: stmmac: dwmac-sophgo: Add phy interface filter



As the SG2042 has an internal rx delay, the delay should be removed
when initializing the mac, otherwise the phy will be misconfigurated.

Fixes: 543009e2 ("net: stmmac: dwmac-sophgo: Add support for Sophgo SG2042 SoC")
Signed-off-by: default avatarInochi Amaoto <inochiama@gmail.com>
Tested-by: default avatarHan Gao <rabenda.cn@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251114003805.494387-4-inochiama@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 24afd782
Loading
Loading
Loading
Loading
+19 −1
Original line number Diff line number Diff line
@@ -7,11 +7,16 @@

#include <linux/clk.h>
#include <linux/module.h>
#include <linux/property.h>
#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>

#include "stmmac_platform.h"

struct sophgo_dwmac_data {
	bool has_internal_rx_delay;
};

static int sophgo_sg2044_dwmac_init(struct platform_device *pdev,
				    struct plat_stmmacenet_data *plat_dat,
				    struct stmmac_resources *stmmac_res)
@@ -31,6 +36,7 @@ static int sophgo_sg2044_dwmac_init(struct platform_device *pdev,
static int sophgo_dwmac_probe(struct platform_device *pdev)
{
	struct plat_stmmacenet_data *plat_dat;
	const struct sophgo_dwmac_data *data;
	struct stmmac_resources stmmac_res;
	struct device *dev = &pdev->dev;
	int ret;
@@ -49,11 +55,23 @@ static int sophgo_dwmac_probe(struct platform_device *pdev)
	if (ret)
		return ret;

	data = device_get_match_data(&pdev->dev);
	if (data && data->has_internal_rx_delay) {
		plat_dat->phy_interface = phy_fix_phy_mode_for_mac_delays(plat_dat->phy_interface,
									  false, true);
		if (plat_dat->phy_interface == PHY_INTERFACE_MODE_NA)
			return -EINVAL;
	}

	return stmmac_dvr_probe(dev, plat_dat, &stmmac_res);
}

static const struct sophgo_dwmac_data sg2042_dwmac_data = {
	.has_internal_rx_delay = true,
};

static const struct of_device_id sophgo_dwmac_match[] = {
	{ .compatible = "sophgo,sg2042-dwmac" },
	{ .compatible = "sophgo,sg2042-dwmac", .data = &sg2042_dwmac_data },
	{ .compatible = "sophgo,sg2044-dwmac" },
	{ /* sentinel */ }
};