Unverified Commit db7155b5 authored by Xi Pardee's avatar Xi Pardee Committed by Ilpo Järvinen
Browse files

platform/x86:intel/pmc: Make tgl_core_generic_init() static 



Make tgl_core_generic_init() a static function as the function has no
callers outside of tgl.c. Remove the prototype in core.h and reorder
the code in tgl.c.

Signed-off-by: default avatarXi Pardee <xi.pardee@linux.intel.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20250207225615.401235-2-xi.pardee@linux.intel.com


Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 0738c302

drivers/platform/x86/intel/pmc/core.h

+0 −1
Original line number Diff line number Diff line
@@ -597,7 +597,6 @@ int cnp_core_init(struct pmc_dev *pmcdev); 
int icl_core_init(struct pmc_dev *pmcdev);

int tgl_core_init(struct pmc_dev *pmcdev);

int tgl_l_core_init(struct pmc_dev *pmcdev);

int tgl_core_generic_init(struct pmc_dev *pmcdev, int pch_tp);

int adl_core_init(struct pmc_dev *pmcdev);

int mtl_core_init(struct pmc_dev *pmcdev);

int arl_core_init(struct pmc_dev *pmcdev);

drivers/platform/x86/intel/pmc/tgl.c

+11 −11
Original line number Diff line number Diff line
@@ -285,17 +285,7 @@ void pmc_core_get_tgl_lpm_reqs(struct platform_device *pdev) 
	ACPI_FREE(out_obj);

}



int tgl_l_core_init(struct pmc_dev *pmcdev)

{

	return tgl_core_generic_init(pmcdev, PCH_LP);

}



int tgl_core_init(struct pmc_dev *pmcdev)

{

	return tgl_core_generic_init(pmcdev, PCH_H);

}



int tgl_core_generic_init(struct pmc_dev *pmcdev, int pch_tp)

static int tgl_core_generic_init(struct pmc_dev *pmcdev, int pch_tp)

{

	struct pmc *pmc = pmcdev->pmcs[PMC_IDX_MAIN];

	int ret;
@@ -317,3 +307,13 @@ int tgl_core_generic_init(struct pmc_dev *pmcdev, int pch_tp) 


	return 0;

}



int tgl_l_core_init(struct pmc_dev *pmcdev)

{

	return tgl_core_generic_init(pmcdev, PCH_LP);

}



int tgl_core_init(struct pmc_dev *pmcdev)

{

	return tgl_core_generic_init(pmcdev, PCH_H);

}