Commit db82b8db authored Oct 20, 2025 by Rafael J. Wysocki

PM: runtime: Fix conditional guard definitions



Since pm_runtime_get_active() returns 0 on success, all of the
DEFINE_GUARD_COND() macros in pm_runtime.h need the "_RET == 0"
condition at the end of the argument list or they would not work
correctly.

Fixes: 9a0abc39 ("PM: runtime: Add auto-cleanup macros for "resume and get" operations")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/linux-pm/202510191529.BCyjKlLQ-lkp@intel.com/


Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Tested-by: Farhan Ali <alifm@linux.ibm.com>
Link: https://patch.msgid.link/5943878.DvuYhMxLoT@rafael.j.wysocki

parent 211ddde0

include/linux/pm_runtime.h

+4 −4

Original line number	Diff line number	Diff line
		@@ -629,13 +629,13 @@ DEFINE_GUARD(pm_runtime_active_auto, struct device *,
		* device.
		*/
		DEFINE_GUARD_COND(pm_runtime_active, _try,
		pm_runtime_get_active(_T, RPM_TRANSPARENT))
		pm_runtime_get_active(_T, RPM_TRANSPARENT), _RET == 0)
		DEFINE_GUARD_COND(pm_runtime_active, _try_enabled,
		pm_runtime_resume_and_get(_T))
		pm_runtime_resume_and_get(_T), _RET == 0)
		DEFINE_GUARD_COND(pm_runtime_active_auto, _try,
		pm_runtime_get_active(_T, RPM_TRANSPARENT))
		pm_runtime_get_active(_T, RPM_TRANSPARENT), _RET == 0)
		DEFINE_GUARD_COND(pm_runtime_active_auto, _try_enabled,
		pm_runtime_resume_and_get(_T))
		pm_runtime_resume_and_get(_T), _RET == 0)

		/**
		* pm_runtime_put_sync - Drop device usage counter and run "idle check" if 0.