Commit dbd31c71 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: eic-sprd: unregister from the irq notifier on remove() 



This is a tristate module, it can be unloaded. We need to cleanup properly
and unregister from the interrupt notifier on driver detach.

Fixes: b3241565 ("gpio: eic-sprd: use atomic notifiers to notify all chips about irqs")
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: default avatarBaolin Wang <baolin.wang@linux.alibaba.com>
parent a5c612b9

drivers/gpio/gpio-eic-sprd.c

+17 −2
Original line number Diff line number Diff line
@@ -580,6 +580,14 @@ static const struct irq_chip sprd_eic_irq = { 
	.flags		= IRQCHIP_SKIP_SET_WAKE | IRQCHIP_IMMUTABLE,

	GPIOCHIP_IRQ_RESOURCE_HELPERS,

};



static void sprd_eic_unregister_notifier(void *data)

{

	struct notifier_block *nb = data;



	atomic_notifier_chain_unregister(&sprd_eic_irq_notifier, nb);

}



static int sprd_eic_probe(struct platform_device *pdev)

{

	const struct sprd_eic_variant_data *pdata;
@@ -658,7 +666,14 @@ static int sprd_eic_probe(struct platform_device *pdev) 
	}



	sprd_eic->irq_nb.notifier_call = sprd_eic_irq_notify;

	return atomic_notifier_chain_register(&sprd_eic_irq_notifier,

	ret = atomic_notifier_chain_register(&sprd_eic_irq_notifier,

					     &sprd_eic->irq_nb);

	if (ret)

		return dev_err_probe(&pdev->dev, ret,

				     "Failed to register with the interrupt notifier");



	return devm_add_action_or_reset(&pdev->dev,

					sprd_eic_unregister_notifier,

					&sprd_eic->irq_nb);

}