Commit dc1dea79 authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by Jakub Kicinski
Browse files

tcp: Remove stale locking comment for TFO. 



The listener -> child locking no longer exists in the fast path
since commit e994b2f0 ("tcp: do not lock listener to process
SYN packets").

Let's remove the stale comment for reqsk_fastopen_remove().

Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20250923005441.4131554-1-kuniyu@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e8ab2317

net/core/request_sock.c

+1 −3
Original line number Diff line number Diff line
@@ -77,9 +77,7 @@ void reqsk_queue_alloc(struct request_sock_queue *queue) 
 * a simple spin lock - one must consider sock_owned_by_user() and arrange

 * to use sk_add_backlog() stuff. But what really makes it infeasible is the

 * locking hierarchy violation. E.g., inet_csk_listen_stop() may try to

 * acquire a child's lock while holding listener's socket lock. A corner

 * case might also exist in tcp_v4_hnd_req() that will trigger this locking

 * order.

 * acquire a child's lock while holding listener's socket lock.

 *

 * This function also sets "treq->tfo_listener" to false.

 * treq->tfo_listener is used by the listener so it is protected by the