Unverified Commit dcbaaa23 authored by Lucas Stach's avatar Lucas Stach Committed by Robert Foss
Browse files

drm/bridge: analogix_dp: remove clk handling from analogix_dp_set_bridge 



The clock is already managed by runtime PM, which is properly invoked
from the analogix_dp_set_bridge function, so there is no need for an
additional reference.

Signed-off-by: default avatarLucas Stach <l.stach@pengutronix.de>
Reviewed-by: default avatarRobert Foss <rfoss@kernel.org>
Tested-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarRobert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240619182200.3752465-6-l.stach@pengutronix.de
parent e7514df0

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

+1 −10
Original line number Diff line number Diff line
@@ -1251,12 +1251,6 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp) 


	pm_runtime_get_sync(dp->dev);



	ret = clk_prepare_enable(dp->clock);

	if (ret < 0) {

		DRM_ERROR("Failed to prepare_enable the clock clk [%d]\n", ret);

		goto out_dp_clk_pre;

	}



	if (dp->plat_data->power_on)

		dp->plat_data->power_on(dp->plat_data);
@@ -1290,8 +1284,7 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp) 
	phy_power_off(dp->phy);

	if (dp->plat_data->power_off)

		dp->plat_data->power_off(dp->plat_data);

	clk_disable_unprepare(dp->clock);

out_dp_clk_pre:



	pm_runtime_put_sync(dp->dev);



	return ret;
@@ -1360,8 +1353,6 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge) 
	analogix_dp_set_analog_power_down(dp, POWER_ALL, 1);

	phy_power_off(dp->phy);



	clk_disable_unprepare(dp->clock);



	pm_runtime_put_sync(dp->dev);



	ret = analogix_dp_prepare_panel(dp, false, true);