Commit dcf69599 authored by Haoxiang Li's avatar Haoxiang Li Committed by Helge Deller
Browse files

parisc: kernel: replace kfree() with put_device() in create_tree_node() 



If device_register() fails, put_device() is the correct way to
drop the device reference.

Found by code review.

Fixes: 1070c965 ("[PA-RISC] Fix must_check warnings in drivers.c")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarHaoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 8f0b4cce

arch/parisc/kernel/drivers.c

+1 −1
Original line number Diff line number Diff line
@@ -435,7 +435,7 @@ static struct parisc_device * __init create_tree_node(char id, 
	dev->dev.dma_mask = &dev->dma_mask;

	dev->dev.coherent_dma_mask = dev->dma_mask;

	if (device_register(&dev->dev)) {

		kfree(dev);

		put_device(&dev->dev);

		return NULL;

	}