Commit dd4299af authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: core: Move an assignment in ufshcd_mcq_process_cqe() 



Since 'tag' is only used inside the if-statement, move the 'tag'
assignment into the if-statement. This patch prepares for introducing a
WARN_ON_ONCE() call in ufshcd_mcq_get_tag() if the tag lookup fails.

Reviewed-by: default avatarAvri Altman <avri.altman@sandisk.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/20251031204029.2883185-9-bvanassche@acm.org


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 581ca490

drivers/ufs/core/ufs-mcq.c

+2 −1
Original line number Diff line number Diff line
@@ -307,9 +307,10 @@ static void ufshcd_mcq_process_cqe(struct ufs_hba *hba, 
				   struct ufs_hw_queue *hwq)

{

	struct cq_entry *cqe = ufshcd_mcq_cur_cqe(hwq);

	int tag = ufshcd_mcq_get_tag(hba, cqe);



	if (cqe->command_desc_base_addr) {

		int tag = ufshcd_mcq_get_tag(hba, cqe);



		ufshcd_compl_one_cqe(hba, tag, cqe);

		/* After processed the cqe, mark it empty (invalid) entry */

		cqe->command_desc_base_addr = 0;