Commit dd7fca9f authored by David Yang's avatar David Yang Committed by Jakub Kicinski
Browse files

net: bridge: mcast: fix memcpy with u64_stats 



On 64bit arches, struct u64_stats_sync is empty and provides no help
against load/store tearing. memcpy() should not be considered atomic
against u64 values. Use u64_stats_copy() instead.

Signed-off-by: default avatarDavid Yang <mmyangfl@gmail.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20260120092137.2161162-3-mmyangfl@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent df153517

net/bridge/br_multicast.c

+1 −1
Original line number Diff line number Diff line
@@ -5201,7 +5201,7 @@ void br_multicast_get_stats(const struct net_bridge *br, 


		do {

			start = u64_stats_fetch_begin(&cpu_stats->syncp);

			memcpy(&temp, &cpu_stats->mstats, sizeof(temp));

			u64_stats_copy(&temp, &cpu_stats->mstats, sizeof(temp));

		} while (u64_stats_fetch_retry(&cpu_stats->syncp, start));



		mcast_stats_add_dir(tdst.igmp_v1queries, temp.igmp_v1queries);