Commit dd83f482 authored by Kamal Heib's avatar Kamal Heib Committed by Jason Gunthorpe
Browse files

RDMA/bnxt_re: Remove unsupported bnxt_re_modify_ah callback 

There is no need to return always zero for function which is not
supported, especially since 0 is the wrong return code.

Link: https://lore.kernel.org/r/20211102073054.410838-1-kamalheib1@gmail.com


Signed-off-by: default avatarKamal Heib <kamalheib1@gmail.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 6a463bc9

drivers/infiniband/hw/bnxt_re/ib_verbs.c

+0 −5
Original line number Diff line number Diff line
@@ -708,11 +708,6 @@ int bnxt_re_create_ah(struct ib_ah *ib_ah, struct rdma_ah_init_attr *init_attr, 
	return 0;

}



int bnxt_re_modify_ah(struct ib_ah *ib_ah, struct rdma_ah_attr *ah_attr)

{

	return 0;

}



int bnxt_re_query_ah(struct ib_ah *ib_ah, struct rdma_ah_attr *ah_attr)

{

	struct bnxt_re_ah *ah = container_of(ib_ah, struct bnxt_re_ah, ib_ah);

drivers/infiniband/hw/bnxt_re/ib_verbs.h

+0 −1
Original line number Diff line number Diff line
@@ -166,7 +166,6 @@ int bnxt_re_alloc_pd(struct ib_pd *pd, struct ib_udata *udata); 
int bnxt_re_dealloc_pd(struct ib_pd *pd, struct ib_udata *udata);

int bnxt_re_create_ah(struct ib_ah *ah, struct rdma_ah_init_attr *init_attr,

		      struct ib_udata *udata);

int bnxt_re_modify_ah(struct ib_ah *ah, struct rdma_ah_attr *ah_attr);

int bnxt_re_query_ah(struct ib_ah *ah, struct rdma_ah_attr *ah_attr);

int bnxt_re_destroy_ah(struct ib_ah *ah, u32 flags);

int bnxt_re_create_srq(struct ib_srq *srq,

drivers/infiniband/hw/bnxt_re/main.c

+0 −1
Original line number Diff line number Diff line
@@ -696,7 +696,6 @@ static const struct ib_device_ops bnxt_re_dev_ops = { 
	.get_port_immutable = bnxt_re_get_port_immutable,

	.map_mr_sg = bnxt_re_map_mr_sg,

	.mmap = bnxt_re_mmap,

	.modify_ah = bnxt_re_modify_ah,

	.modify_qp = bnxt_re_modify_qp,

	.modify_srq = bnxt_re_modify_srq,

	.poll_cq = bnxt_re_poll_cq,