Commit ddf2cb3c authored by Boris Brezillon's avatar Boris Brezillon
Browse files

drm/panthor: Relax a check in panthor_sched_pre_reset() 



Groups are only moved out of the runnable lists when
panthor_group_stop() is called or when they run out of jobs.
What should not happen though is having one group added to one of
the runnable list after reset.in_progress has been set to true, but
that's not something we can easily check, so let's just drop the
WARN_ON() in panthor_sched_pre_reset().

v2:
- Adjust explanation in commit message

v3:
- Collect R-b

v4:
- No changes

Reviewed-by: default avatarLiviu Dudau <liviu.dudau@arm.com>
Reviewed-by: default avatarSteven Price <steven.price@arm.com>
Link: https://patch.msgid.link/20251128084841.3804658-7-boris.brezillon@collabora.com


Signed-off-by: default avatarBoris Brezillon <boris.brezillon@collabora.com>
parent 19e8bc94

drivers/gpu/drm/panthor/panthor_sched.c

+0 −2
Original line number Diff line number Diff line
@@ -2937,8 +2937,6 @@ void panthor_sched_pre_reset(struct panthor_device *ptdev) 
	 * new jobs while we're resetting.

	 */

	for (i = 0; i < ARRAY_SIZE(sched->groups.runnable); i++) {

		/* All groups should be in the idle lists. */

		drm_WARN_ON(&ptdev->base, !list_empty(&sched->groups.runnable[i]));

		list_for_each_entry_safe(group, group_tmp, &sched->groups.runnable[i], run_node)

			panthor_group_stop(group);

	}