Commit de06b42e authored by Jani Nikula's avatar Jani Nikula
Browse files

drm/i915: don't make assumptions about intel_wakeref_t type 



intel_wakeref_t is supposed to be a mostly opaque cookie to its
users. It should only be checked for being non-zero and set to
zero. Debug logging its actual value is meaningless. Switch to just
debug logging whether the async_put_wakeref is non-zero.

The issue dates back to much earlier than
commit b49e894c ("drm/i915: Replace custom intel runtime_pm tracker
with ref_tracker library"), but this is the one that brought about a
build failure due to the printf format.

Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/r/20240102111222.2db11208@canb.auug.org.au


Fixes: b49e894c ("drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library")
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Reviewed-by: default avatarImre Deak <imre.deak@intel.com>
Reviewed-by: default avatarAndrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240104164600.783371-1-jani.nikula@intel.com
parent 835e4d9b

drivers/gpu/drm/i915/display/intel_display_power.c

+2 −2
Original line number Diff line number Diff line
@@ -405,8 +405,8 @@ print_async_put_domains_state(struct i915_power_domains *power_domains) 
						     struct drm_i915_private,

						     display.power.domains);



	drm_dbg(&i915->drm, "async_put_wakeref %lu\n",

		power_domains->async_put_wakeref);

	drm_dbg(&i915->drm, "async_put_wakeref: %s\n",

		str_yes_no(power_domains->async_put_wakeref));



	print_power_domains(power_domains, "async_put_domains[0]",

			    &power_domains->async_put_domains[0]);