Commit de0aca13 authored by Eliot Courtney's avatar Eliot Courtney Committed by Danilo Krummrich
Browse files

gpu: nova-core: bitfield: fix broken Default implementation 



The current implementation does not actually set the default values for
the fields in the bitfield.

Fixes: 3fa145be ("gpu: nova-core: register: generate correct `Default` implementation")
Signed-off-by: default avatarEliot Courtney <ecourtney@nvidia.com>
Link: https://patch.msgid.link/20260401-fix-bitfield-v2-1-2fa68c98114a@nvidia.com


Signed-off-by: default avatarDanilo Krummrich <dakr@kernel.org>
parent 0e0ffbcd

drivers/gpu/nova-core/bitfield.rs

+2 −3
Original line number Diff line number Diff line
@@ -314,12 +314,11 @@ fn fmt(&self, f: &mut ::kernel::fmt::Formatter<'_>) -> ::kernel::fmt::Result { 
        /// Returns a value for the bitfield where all fields are set to their default value.

        impl ::core::default::Default for $name {

            fn default() -> Self {

                #[allow(unused_mut)]

                let mut value = Self(Default::default());

                let value = Self(Default::default());



                ::kernel::macros::paste!(

                $(

                value.[<set_ $field>](Default::default());

                let value = value.[<set_ $field>](Default::default());

                )*

                );