Commit de1c705c authored by Dmitry Baryshkov's avatar Dmitry Baryshkov
Browse files

drm/mipi-dsi: use correct return type for the DSC functions 



The functions mipi_dsi_compression_mode() and
mipi_dsi_picture_parameter_set() return 0-or-error rather than a buffer
size. Follow example of other similar MIPI DSI functions and use int
return type instead of size_t.

Fixes: f4dea1aa ("drm/dsi: add helpers for DSI compression mode and PPS packets")
Reviewed-by: default avatarMarijn Suijten <marijn.suijten@somainline.org>
Reviewed-by: default avatarJessica Zhang <quic_jesszhan@quicinc.com>
Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240408-lg-sw43408-panel-v5-2-4e092da22991@linaro.org
parent bf6302ec

drivers/gpu/drm/drm_mipi_dsi.c

+3 −3
Original line number Diff line number Diff line
@@ -654,7 +654,7 @@ EXPORT_SYMBOL(mipi_dsi_set_maximum_return_packet_size); 
 *

 * Return: 0 on success or a negative error code on failure.

 */

ssize_t mipi_dsi_compression_mode(struct mipi_dsi_device *dsi, bool enable)

int mipi_dsi_compression_mode(struct mipi_dsi_device *dsi, bool enable)

{

	/* Note: Needs updating for non-default PPS or algorithm */

	u8 tx[2] = { enable << 0, 0 };
@@ -679,7 +679,7 @@ EXPORT_SYMBOL(mipi_dsi_compression_mode); 
 *

 * Return: 0 on success or a negative error code on failure.

 */

ssize_t mipi_dsi_picture_parameter_set(struct mipi_dsi_device *dsi,

int mipi_dsi_picture_parameter_set(struct mipi_dsi_device *dsi,

				   const struct drm_dsc_picture_parameter_set *pps)

{

	struct mipi_dsi_msg msg = {

include/drm/drm_mipi_dsi.h

+3 −3
Original line number Diff line number Diff line
@@ -241,8 +241,8 @@ int mipi_dsi_shutdown_peripheral(struct mipi_dsi_device *dsi); 
int mipi_dsi_turn_on_peripheral(struct mipi_dsi_device *dsi);

int mipi_dsi_set_maximum_return_packet_size(struct mipi_dsi_device *dsi,

					    u16 value);

ssize_t mipi_dsi_compression_mode(struct mipi_dsi_device *dsi, bool enable);

ssize_t mipi_dsi_picture_parameter_set(struct mipi_dsi_device *dsi,

int mipi_dsi_compression_mode(struct mipi_dsi_device *dsi, bool enable);

int mipi_dsi_picture_parameter_set(struct mipi_dsi_device *dsi,

				   const struct drm_dsc_picture_parameter_set *pps);



ssize_t mipi_dsi_generic_write(struct mipi_dsi_device *dsi, const void *payload,