Commit de1e963a authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: stmmac: rk: put the PHY clock on remove 



The PHY clock (bsp_priv->clk_phy) is obtained using of_clk_get(), which
doesn't take part in the devm release. Therefore, when a device is
unbound, this clock needs to be explicitly put. Fix this.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Fixes: fecd4d7e ("net: stmmac: dwmac-rk: Add integrated PHY support")
Link: https://patch.msgid.link/E1ukM1S-0086qo-PC@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 52966bf7

drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c

+5 −1
Original line number Diff line number Diff line
@@ -1765,11 +1765,15 @@ static int rk_gmac_probe(struct platform_device *pdev) 


static void rk_gmac_remove(struct platform_device *pdev)

{

	struct rk_priv_data *bsp_priv = get_stmmac_bsp_priv(&pdev->dev);

	struct stmmac_priv *priv = netdev_priv(platform_get_drvdata(pdev));

	struct rk_priv_data *bsp_priv = priv->plat->bsp_priv;



	stmmac_dvr_remove(&pdev->dev);



	rk_gmac_powerdown(bsp_priv);



	if (priv->plat->phy_node && bsp_priv->integrated_phy)

		clk_put(bsp_priv->clk_phy);

}



#ifdef CONFIG_PM_SLEEP