Commit de379dfd authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

selftests: drv-net: rss_ctx: add missing cleanup in queue reconfigure 



Commit under Fixes adds ntuple rules but never deletes them.

Fixes: 29a4bc1f ("selftest: extend test_rss_context_queue_reconfigure for action addition")
Reviewed-by: default avatarJoe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/20250201013040.725123-4-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 2b91cc12

tools/testing/selftests/drivers/net/hw/rss_ctx.py

+2 −0
Original line number Diff line number Diff line
@@ -252,6 +252,7 @@ def test_rss_queue_reconfigure(cfg, main_ctx=True): 
        try:

            # this targets queue 4, which doesn't exist

            ntuple2 = ethtool_create(cfg, "-N", flow)

            defer(ethtool, f"-N {cfg.ifname} delete {ntuple2}")

        except CmdExitFailure:

            pass

        else:
@@ -260,6 +261,7 @@ def test_rss_queue_reconfigure(cfg, main_ctx=True): 
        ethtool(f"-X {cfg.ifname} {ctx_ref} weight 1 0 1 0")

        # ntuple rule therefore targets queues 1 and 3

        ntuple2 = ethtool_create(cfg, "-N", flow)

        defer(ethtool, f"-N {cfg.ifname} delete {ntuple2}")

        # should replace existing filter

        ksft_eq(ntuple, ntuple2)

        _send_traffic_check(cfg, port, ctx_ref, { 'target': (1, 3),