Commit de676875 authored by Michael Chan's avatar Michael Chan Committed by Paolo Abeni
Browse files

bnxt_en: Improve bnxt_backing_store_cfg_v2() 



Improve the logic that determines the last_type in this function.
The different context memory types are configured in a loop.  The
last_type signals the last context memory type to be configured
which requires the ALL_DONE flag to be set for the FW.

The existing logic makes some assumptions that TIM is the last_type
when RDMA is enabled or FTQM is the last_type when only L2 is
enabled.  Improve it to just search for the last_type so that we
don't need to make these assumptions that won't necessary be true
for future devices.

Reviewed-by: default avatarShruti Parab <shruti.parab@broadcom.com>
Reviewed-by: default avatarHongguang Gao <hongguang.gao@broadcom.com>
Signed-off-by: default avatarMichael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250917040839.1924698-5-michael.chan@broadcom.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 21b6b8e8

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+8 −7
Original line number Diff line number Diff line
@@ -9150,7 +9150,7 @@ static int bnxt_hwrm_func_backing_store_cfg_v2(struct bnxt *bp, 
	return rc;

}



static int bnxt_backing_store_cfg_v2(struct bnxt *bp, u32 ena)

static int bnxt_backing_store_cfg_v2(struct bnxt *bp)

{

	struct bnxt_ctx_mem_info *ctx = bp->ctx;

	struct bnxt_ctx_mem_type *ctxm;
@@ -9176,12 +9176,13 @@ static int bnxt_backing_store_cfg_v2(struct bnxt *bp, u32 ena) 
	}



	if (last_type == BNXT_CTX_INV) {

		if (!ena)

		for (type = 0; type < BNXT_CTX_MAX; type++) {

			ctxm = &ctx->ctx_arr[type];

			if (ctxm->mem_valid)

				last_type = type;

		}

		if (last_type == BNXT_CTX_INV)

			return 0;

		else if (ena & FUNC_BACKING_STORE_CFG_REQ_ENABLES_TIM)

			last_type = BNXT_CTX_MAX - 1;

		else

			last_type = BNXT_CTX_L2_MAX - 1;

	}

	ctx->ctx_arr[last_type].last = 1;
@@ -9411,7 +9412,7 @@ static int bnxt_alloc_ctx_mem(struct bnxt *bp) 
	ena |= FUNC_BACKING_STORE_CFG_REQ_DFLT_ENABLES;



	if (bp->fw_cap & BNXT_FW_CAP_BACKING_STORE_V2)

		rc = bnxt_backing_store_cfg_v2(bp, ena);

		rc = bnxt_backing_store_cfg_v2(bp);

	else

		rc = bnxt_hwrm_func_backing_store_cfg(bp, ena);

	if (rc) {