Commit de9b8610 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven
Browse files

pinctrl: renesas: checker: Fix miscalculation of number of states 



The checker failed to validate all enum IDs in the description of a
register with fixed-width register fields, due to a miscalculation of
the number of described states: each register field of n bits can have
"1 << n" possible states, not "1".

Increase SH_PFC_MAX_ENUMS accordingly, now more enum IDs are checked
(SH-Mobile AG5 has more than 4000 enum IDs defined).

Fixes: 12d057ba ("pinctrl: sh-pfc: checker: Add check for enum ID conflicts")
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/6d8a6a05564f38f9d20464c1c17f96e52740cf6a.1645460429.git.geert+renesas@glider.be
parent 4704797e

drivers/pinctrl/renesas/core.c

+3 −2
Original line number Diff line number Diff line
@@ -741,7 +741,7 @@ static int sh_pfc_suspend_init(struct sh_pfc *pfc) { return 0; } 


#ifdef DEBUG

#define SH_PFC_MAX_REGS		300

#define SH_PFC_MAX_ENUMS	3000

#define SH_PFC_MAX_ENUMS	5000



static unsigned int sh_pfc_errors __initdata;

static unsigned int sh_pfc_warnings __initdata;
@@ -875,7 +875,8 @@ static void __init sh_pfc_check_cfg_reg(const char *drvname, 
			 GENMASK(cfg_reg->reg_width - 1, 0));



	if (cfg_reg->field_width) {

		n = cfg_reg->reg_width / cfg_reg->field_width;

		fw = cfg_reg->field_width;

		n = (cfg_reg->reg_width / fw) << fw;

		/* Skip field checks (done at build time) */

		goto check_enum_ids;

	}