Commit dea9f847 authored by Lizhi Hou's avatar Lizhi Hou
Browse files

accel/amdxdna: Fix dma_fence leak when job is canceled 



Currently, dma_fence_put(job->fence) is called in job notification
callback. However, if a job is canceled, the notification callback is never
invoked, leading to a memory leak. Move dma_fence_put(job->fence)
to the job cleanup function to ensure the fence is always released.

Fixes: aac24309 ("accel/amdxdna: Add command execution")
Reviewed-by: default avatarMario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: default avatarLizhi Hou <lizhi.hou@amd.com>
Link: https://patch.msgid.link/20251105194140.1004314-1-lizhi.hou@amd.com
parent f23e40e3

drivers/accel/amdxdna/aie2_ctx.c

+0 −1
Original line number Diff line number Diff line
@@ -189,7 +189,6 @@ aie2_sched_notify(struct amdxdna_sched_job *job) 


	up(&job->hwctx->priv->job_sem);

	job->job_done = true;

	dma_fence_put(fence);

	mmput_async(job->mm);

	aie2_job_put(job);

}

drivers/accel/amdxdna/amdxdna_ctx.c

+1 −0
Original line number Diff line number Diff line
@@ -422,6 +422,7 @@ void amdxdna_sched_job_cleanup(struct amdxdna_sched_job *job) 
	trace_amdxdna_debug_point(job->hwctx->name, job->seq, "job release");

	amdxdna_arg_bos_put(job);

	amdxdna_gem_put_obj(job->cmd_bo);

	dma_fence_put(job->fence);

}



int amdxdna_cmd_submit(struct amdxdna_client *client,