Commit e01424fa authored by Bart Van Assche's avatar Bart Van Assche Committed by Jens Axboe
Browse files

mq-deadline: Remove a local variable 



Since commit fde02699 ("block: mq-deadline: Remove support for zone
write locking"), the local variable 'insert_before' is assigned once and
is used once. Hence remove this local variable.

Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarNitesh Shetty <nj.shetty@samsung.com>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/20241212212941.1268662-2-bvanassche@acm.org


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 57e420c8

block/mq-deadline.c

+1 −4
Original line number Diff line number Diff line
@@ -698,8 +698,6 @@ static void dd_insert_request(struct blk_mq_hw_ctx *hctx, struct request *rq, 
		list_add(&rq->queuelist, &per_prio->dispatch);

		rq->fifo_time = jiffies;

	} else {

		struct list_head *insert_before;



		deadline_add_rq_rb(per_prio, rq);



		if (rq_mergeable(rq)) {
@@ -712,8 +710,7 @@ static void dd_insert_request(struct blk_mq_hw_ctx *hctx, struct request *rq, 
		 * set expire time and add to fifo list

		 */

		rq->fifo_time = jiffies + dd->fifo_expire[data_dir];

		insert_before = &per_prio->fifo_list[data_dir];

		list_add_tail(&rq->queuelist, insert_before);

		list_add_tail(&rq->queuelist, &per_prio->fifo_list[data_dir]);

	}

}